New dependency plugin design #953
Draft
+9
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the `TestFormatter` class to use inline constructor syntax, simplifying the code by removing the separate constructor definition. Updated the `ConsumedMessages` property to use the shorthand `[]` for initializing an empty list, improving code readability and conciseness.
Author
Progress report
TestsStarted running tests in Visual Studio. Running all tests is time consuming :-) Aborted testing in Visual Studio to run them from the command line. Tests have been running for approximately 5 minutes now. My goal is the get all tests passing before I start implementation. I'll attempt to acheive this over the weekend. |
Contributor
|
Test execution gets slightly faster for the second run due to some caching. Do not run the "specs" tests locally - those are generally redundant and legacy. The others run for a few minutes for me after the caches are in place. |
Updated the `RuntimePluginLocatorTests` to explicitly order the `foundPlugins` collection alphabetically using `.OrderBy(p => p)`. Reordered the expected plugin list to match the new ordering logic. These changes improve debugging if the test fails.
Updated the list of expected plugin DLLs in the `RuntimePluginLocatorTests` test file to include new generator-related plugins: - Added `Reqnroll.MSTest.Generator.ReqnrollPlugin.dll` - Added `Reqnroll.NUnit.Generator.ReqnrollPlugin.dll` These changes reflect the introduction of generator plugins and ensure the test expectations align with the updated plugin structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
New dependency plugin design.
⚡️ What's your motivation?
Implements
🏷️ What kind of change is this?
📋 Checklist: