Reqnroll.SpecFlowCompatibility 3.3.4 is not published

[304NotModified]

Reqnroll Version

3.3.4

Issue Description

Not sure if this is intended, but the latest version of Reqnroll.SpecFlowCompatibility is 3.3.3, while the other Reqnroll packages have versions 3.3.3 and 3.3.4.

Steps to Reproduce

https://www.nuget.org/packages/Reqnroll.SpecFlowCompatibility/3.3.4 gives not found

Related

https://github.com/orgs/reqnroll/discussions/1043

I think this is the deployment, but the nupkg is also missing here?
https://github.com/reqnroll/Reqnroll/actions/runs/23450237228/job/68227107544

[clrudolphi]

@obligaron Would you mind taking a look? This might be related to the packing change #1058 made a few days ago just before the 3.3.4 release.

[304NotModified]

Thanks @clrudolphi!

Re-enabling IsPackable seems to work see #1070 and #1069. Please double check :)

If this all is OK then I propose

1. Merge Fix creating SpecFlow compat package (v3.x) #1070 (so in to fix-specflow-compat.v3.3.4). We don't need Fix creating SpecFlow compat package (v4.x) #1069, so close that one.
2. create a new tag, v3.3.4-specflow-compat (or something like that) from fix-specflow-compat.v3.3.4
3. release 3.3.4 from that tag to nuget. The existing packages will be skipped :)
4. create a new GitHub release from that tag
5. merge this tag into main. This needs a merge commit, not rebase or squash! (Otherwise is the commit of that release not in main, which is bad)

[clrudolphi]

Re-enabling IsPackable seems to work see #1070 and #1069. Please double check :)

I am not qualified to verify that flipping that property to true is the correct approach. I'm not that familiar with the changes made to the nuget packaging process. I'd prefer to hear from @gasparnagy or @obligaron .

[304NotModified]

@clrudolphi FYI I checked the 3.3.4-ci package, it looks correct. See #1070 (comment)

[clrudolphi]

@clrudolphi FYI I checked the 3.3.4-ci package, it looks correct. See #1070 (comment)

@gasparnagy ?

[obligaron]

With #1058 I overlooked that Reqnroll.SpecFlowCompatibility NuGet package isn't created anymore. Sorry my bad. 🙁

I checked #1070 locally and I still get a compile error (like described in #1057):

Severity	Code	Description	Project	File	Line	Suppression State	Details
Error (active)		Value cannot be null.
Parameter name: key	Reqnroll.SpecFlowCompatibility.ReqnrollPlugin	C:\Program Files\dotnet\sdk\10.0.201\NuGet.Build.Tasks.Pack.targets	222		

@clrudolphi could you compile #1070 locally and see if you also get a compilation error?

[clrudolphi]

With #1058 I overlooked that Reqnroll.SpecFlowCompatibility NuGet package isn't created anymore. Sorry my bad. 🙁

I checked #1070 locally and I still get a compile error (like described in #1057):

Severity	Code	Description	Project	File	Line	Suppression State	Details
Error (active)		Value cannot be null.
Parameter name: key	Reqnroll.SpecFlowCompatibility.ReqnrollPlugin	C:\Program Files\dotnet\sdk\10.0.201\NuGet.Build.Tasks.Pack.targets	222		

@clrudolphi could you compile #1070 locally and see if you also get a compilation error?

I get the same error on #1070.
Is the change made in #1070 the correct one to get the SpecFlow compat plugin packaged?

[304NotModified]

OK confusing, on the CI it also fails now: https://github.com/reqnroll/Reqnroll/actions/runs/24144651153

While the build (with same commit hash) succeeded before: https://github.com/reqnroll/Reqnroll/actions/runs/23622833511