Skip to content

User references instead of copying#12

Merged
repugraf merged 2 commits intomainfrom
impr/use-ref-vs-copying
Nov 10, 2025
Merged

User references instead of copying#12
repugraf merged 2 commits intomainfrom
impr/use-ref-vs-copying

Conversation

@repugraf
Copy link
Owner

No description provided.

@repugraf repugraf requested a review from Copilot November 10, 2025 12:13
@repugraf repugraf self-assigned this Nov 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates function signatures in the TypeConversion namespace and related helper functions to pass Napi::Env as a const reference (const Napi::Env &) instead of by value. While this change is technically valid, it introduces a pattern inconsistency with other similar functions in the codebase.

Key Changes

  • Modified all TypeConversion namespace function signatures to accept Napi::Env by const reference
  • Updated the BusPopWorker::ConvertMessageToJs private method signature accordingly
  • Updated forward declaration in async-workers.hpp to match

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/cpp/type-conversion.hpp Updated function declarations to pass Napi::Env by const reference
src/cpp/type-conversion.cpp Updated function implementations to match header declarations
src/cpp/async-workers.hpp Updated forward declaration and private method signature for gst_sample_to_js and ConvertMessageToJs
src/cpp/async-workers.cpp Updated ConvertMessageToJs implementation to match declaration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@repugraf repugraf requested a review from Copilot November 10, 2025 12:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@repugraf repugraf merged commit 1a459e1 into main Nov 10, 2025
10 checks passed
@repugraf repugraf deleted the impr/use-ref-vs-copying branch November 10, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants