Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates project dependencies and improves the CMake build configuration, focusing on better cross-platform support and modernizing the dependency stack.
- Updated Vitest from 3.2.4 to 4.0.7 (major version upgrade)
- Updated Vite override from 7.1.5 to 7.2.2
- Reorganized CMakeLists.txt to set compiler flags before target creation and improved Windows-specific MSVC settings
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Updated vitest to 4.0.7 and vite override to 7.2.2 |
| package-lock.json | Updated dependency tree to reflect vitest 4.x, including all transitive dependencies like esbuild, @vitest/* packages, and related tooling |
| CMakeLists.txt | Reorganized build type and compiler flag settings, improved Windows-specific MSVC configuration with modern target-based options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
When importing the binding inside Electron app in Windows 11 specifically there was this kind of error:
When running using the package outside of electron app (via node.js direly) this issue wasn't happening
The root cause of this was missing
win_delay_load_hook.ccfile as a source in windows.win_delay_load_hook.ccis a C++ file used in the Windows build process for native Node.js modules, particularly with frameworks likeElectronandNW.js. It implements a delay-load hook to correctly redirect the loading ofnode.dllto the main executable (electron.exeornw.exe), ensuring native modules can be loaded at runtime. This is necessary because these frameworks export the symbols from their executable, not a separatenode.dll.The fix was implemented in existing CMake file first but it required a lot of manual setting which is already node in
node-gyppackage. The decision was made to mode to gyp enterally to prevent future such issues.