Skip to content

[#1116] Code Panel: weird syntax highlighting #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fzdy1914 merged 2 commits into from
Apr 23, 2021
Merged

[#1116] Code Panel: weird syntax highlighting #1521

fzdy1914 merged 2 commits into from
Apr 23, 2021

Conversation

@gerhean
Copy link
Contributor

@gerhean gerhean commented Apr 2, 2021

Fixes #1116

Reposense frontend is using highlightjs@9.14 which has
some highlighting issues.

This issue was fixed by the following PR in highlightjs:
https://github.com/highlightjs/highlight.js/pull/2531

Let's update highlightjs to 10.7.1 in reposense.

@gerhean gerhean requested a review from a team April 2, 2021 06:15
@dcshzj
Copy link
Member

dcshzj commented Apr 2, 2021

To clarify, anything that we need to take note of from their upgrading notes?

Tejas2805
Tejas2805 approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@Tejas2805 Tejas2805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0blivious 0blivious requested a review from a team April 20, 2021 14:48
@fzdy1914 fzdy1914 merged commit 4dec579 into reposense:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tejas2805 Tejas2805 Tejas2805 approved these changes

@HCY123902 HCY123902 HCY123902 approved these changes

+1 more reviewer

@0blivious 0blivious 0blivious approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

s.FinalReview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Code Panel: weird syntax highlighting

6 participants

@gerhean @dcshzj @Tejas2805 @0blivious @HCY123902 @fzdy1914