Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RP_ENABLED and enabled configuration possibility and fix documentation #114

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Jonathan-Carvalheiro
Copy link
Contributor

Possibility to disable the agent with enabled configuration or RP_ENABLED environment variable

@AmsterGet AmsterGet self-requested a review September 30, 2022 14:06
@AmsterGet AmsterGet changed the base branch from master to develop October 31, 2022 20:58
@AmsterGet
Copy link
Member

Hello @Jonathan-Carvalheiro !
Thank you for your PR.
Is an additional setting required to stop sending reports to the Report Portal?
Is it possible to configure disabling/enabling specific reporter via the jest config?

@Jonathan-Carvalheiro
Copy link
Contributor Author

Hello @Jonathan-Carvalheiro ! Thank you for your PR. Is an additional setting required to stop sending reports to the Report Portal? Is it possible to configure disabling/enabling specific reporter via the jest config?

Yes this ais n extra setting to disable the RP. It will be on until you define on the jest config the enabled=false or by environment variable RP_ENABLED=false.

Copy link
Member

@AmsterGet AmsterGet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also rebase under the latest develop to apply code style checks.

@@ -41,6 +41,7 @@ class JestReportPortal {
constructor(globalConfig, options) {
const agentInfo = getAgentInfo();
this.reportOptions = getClientInitObject(getOptions.options(options));
if(this.reportOptions.enabled ==='false') return {invalid:true};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain this line?
What is "invalid: true" here, does it have some specification?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants