Skip to content

catch construct error and re-report as protocol error#353

Merged
jackyzha0 merged 2 commits intomainfrom
jackyzha0/river-catch-construct-err
Dec 12, 2025
Merged

catch construct error and re-report as protocol error#353
jackyzha0 merged 2 commits intomainfrom
jackyzha0/river-catch-construct-err

Conversation

@jackyzha0
Copy link
Member

Why

construct can reject and cause an otherwise uncaught async rejection

What changed

catch construct error and re-report as protocol error

Versioning

  • Breaking protocol change
  • Breaking ts/js API change

@jackyzha0 jackyzha0 requested a review from a team as a code owner December 12, 2025 01:22
@jackyzha0 jackyzha0 requested review from daweifeng-replit and removed request for a team December 12, 2025 01:22
@jackyzha0 jackyzha0 merged commit 1d02e1f into main Dec 12, 2025
9 of 10 checks passed
@jackyzha0 jackyzha0 deleted the jackyzha0/river-catch-construct-err branch December 12, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants