Move ServerTransport specific methods from Transport to ServerTransport#85
Merged
masad-frost merged 1 commit intomainfrom Sep 23, 2024
Conversation
Member
Author
|
Current dependencies on/for this PR:
This comment was autogenerated by Freephite. |
This was referenced Sep 14, 2024
jackyzha0
approved these changes
Sep 14, 2024
| async def close(self) -> None: | ||
| await self._close_all_sessions() | ||
|
|
||
| async def _get_or_create_session( |
Member
There was a problem hiding this comment.
we should deprecate this eventually like we did with ts, server should never need this
Base automatically changed from
09-13-Add_a_couple_of_environment_setup_files
to
main
September 23, 2024 17:12
masad-frost
force-pushed
the
09-13-Move_ServerTransport_specific_methods_from_Transport_to_ServerTransport
branch
from
a97f4ec to
ca37377
Compare
masad-frost
force-pushed
the
09-13-Move_ServerTransport_specific_methods_from_Transport_to_ServerTransport
branch
from
ca37377 to
e411a9e
Compare
masad-frost
deleted the
09-13-Move_ServerTransport_specific_methods_from_Transport_to_ServerTransport
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
method is not shared
What changed
Just moved some stuff around, see diff.