[bug] Avoiding mixing type rendering and unstructured codegen#146
Merged
blast-hardcheese merged 8 commits intomainfrom Mar 18, 2025
Merged
[bug] Avoiding mixing type rendering and unstructured codegen#146blast-hardcheese merged 8 commits intomainfrom
blast-hardcheese merged 8 commits intomainfrom
Conversation
blast-hardcheese
requested review from
jackyzha0 and
ryantm
and removed request for
a team
blast-hardcheese
force-pushed
the
dstewart/bug/notrequired-bug
branch
from
2dc716e to
ef9eacb
Compare
Member
|
can we add a quick codegen test for sanity? looks good otherwise |
Contributor
Author
|
Yep -- that's part of the TODO |
jackyzha0
approved these changes
Mar 18, 2025
blast-hardcheese
force-pushed
the
dstewart/bug/notrequired-bug
branch
from
dfa7089 to
238a41c
Compare
blast-hardcheese
force-pushed
the
dstewart/bug/notrequired-bug
branch
from
238a41c to
bcb25f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Introduced in #142,
NotRequired[A] | Nonedoesn't typecheck, but we didn't have any codegen tests that exhausted that path.What changed
Move the statically rendered
${render(...)} | Noneinto${render(UnionTypeExpr([..., NoneTypeExpr()]))}so the type renderer knows about and can properly unify/deduplicate/render the structured union.Test plan
TODO: Add a test that makes it so we don't regress here in the future.