Ensure WebSocket is always marked as closed after getting ConnectionClosed error

[cbrewster]

Why

When we received a ConnectionClosed error while reading from the WebSocket, we were not marking the ws_wrapper as closed. This meant that the reconnection code thought that there was already an open WebSocket connection and did not attempt reconnection. Leaving the session stuck until the grace period elapses.

What changed

• Always call close_websocket after getting a ConnectionClosed error so that the bookkeeping is up to date
  • This unifies some of the codepaths so we perform the same logic no matter where the disconnect error happens
  • Also renamed _handle_connection_closed so its more clear
• close_websocket also handles triggering a reconnect, if enabled

Test plan

• TBD

[cbrewster]

Current dependencies on/for this PR:

• main:
  • PR Ensure WebSocket is always marked as closed after getting ConnectionClosed error #132 👈

This comment was autogenerated by Freephite.

[jackyzha0]

seems like we lost the _retry_connection_callback callback here?

[cbrewster]

That is already handled down inside close_websocket:

river-python/replit_river/session.py

Lines 454 to 455 in 235406c

	if should_retry and self._retry_connection_callback:
	self._task_manager.create_task(self._retry_connection_callback())