Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change resolvedFromSearch content #1629

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

nvanthao
Copy link
Member

Description, Motivation and Context

Please include a summary of the change or what problem it solves. Please also include relevant motivation and context.

Fixes: replicatedhq/embedded-cluster#1210

Changed content of .resolvedFromSearch. E.g. from .foo.testcluster.net. to foo.testcluster.net

{
  "query": {
    "*": [
      {
        "server": "127.0.0.53:53",
        "search": "foo.testcluster.net",
        "name": "*.foo.testcluster.net.",
        "answer": "*.foo.testcluster.net.\t60\tIN\tA\t192.1.2.3",
        "record": "192.1.2.3"
      },
      {
        "server": "127.0.0.53:53",
        "search": "",
        "name": "*.c.replicated-qa.internal.",
        "answer": "",
        "record": ""
      },
      {
        "server": "127.0.0.53:53",
        "search": "",
        "name": "*.google.internal.",
        "answer": "",
        "record": ""
      },
      {
        "server": "127.0.0.53:53",
        "search": "",
        "name": "*.",
        "answer": "",
        "record": ""
      }
    ]
  },
  "resolvedFromSearch": "foo.testcluster.net"
}
[
    {
        "name": "detect.wildcard.dns",
        "labels": {
            "desiredPosition": "1",
            "iconKey": "kubernetes_text_analyze",
            "iconUri": "https://troubleshoot.sh/images/analyzer-icons/text-analyze.svg"
        },
        "insight": {
            "name": "detect.wildcard.dns",
            "labels": {
                "iconKey": "kubernetes_text_analyze",
                "iconUri": "https://troubleshoot.sh/images/analyzer-icons/text-analyze.svg"
            },
            "primary": "Detect wildcard DNS",
            "detail": "Wildcard DNS entry foo.testcluster.net detected. Remove the wildcard DNS entry or the foo.testcluster.net search domain from resolv.conf.",
            "severity": "error"
        },
        "severity": "error",
        "analyzerSpec": "",
        "error": "Wildcard DNS entry foo.testcluster.net detected. Remove the wildcard DNS entry or the foo.testcluster.net search domain from resolv.conf."
    }
]

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@nvanthao nvanthao requested a review from a team as a code owner September 30, 2024 00:24
@nvanthao nvanthao added the type::feature New feature or request label Sep 30, 2024
@nvanthao nvanthao merged commit d60f9a6 into main Sep 30, 2024
27 checks passed
@nvanthao nvanthao deleted the gerard/host-preflight-dns-text branch September 30, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::chore type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants