Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GORELEASER_PREVIOUS_TAG #468

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Use GORELEASER_PREVIOUS_TAG #468

merged 1 commit into from
Oct 30, 2024

Conversation

divolgin
Copy link
Member

            • git state                                      commit=9a978c1cfb267543b95350f317766f52cc6d3f29 branch=release-0.83.12 current_tag=v0.83.11 previous_tag=v0.83.6 dirty=false
          ⨯ release failed after 0s                          error=git tag v0.83.11 was not made against commit 9a978c1cfb267543b95350f317766f52cc6d3f29

current_tag and previous_tag values are wrong when making next release:

current_tag=v0.83.11 previous_tag=v0.83.6
should be
current_tag=v0.83.12 previous_tag=v0.83.11

@@ -173,7 +175,8 @@ func (r *Replicated) Release(
Version: goreleaserVersion,
}).Ctr().
WithSecretVariable("GITHUB_TOKEN", githubToken).
WithEnvVariable("GORELEASER_CURRENT_TAG", latestVersion)
WithEnvVariable("GORELEASER_CURRENT_TAG", nextVersionTag).
WithEnvVariable("GORELEASER_PREVIOUS_TAG", previousVersionTag)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix is on these two lines

@divolgin divolgin merged commit d96876a into main Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants