Add log basic support bundle specs #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banjoh
approved these changes
Jun 12, 2025
| @@ -0,0 +1,12 @@ | |||
| {{- define "cert-manager.supportbundle" -}} | |||
There was a problem hiding this comment.
Nice approach of using tpl helpers. It makes editing the spec easier and less error prone such as getting indentations wrong.
Something to consider is adding a way to test a spec is valid. Just rendering it using support-bundle --dry-run should suffice. If you'd like, you can compare the number of collectors & analysers from the dry run output with an expected number.
There was a problem hiding this comment.
The test would then be added to the CI workflow once #69 is merged
There was a problem hiding this comment.
Cool, I'll have a think about testing in a future PR. a common testing framework for "does my support bundle do what I thought it did" would be nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds log collectors for: