Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the error message when failing to download kots binaries #4999

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

improve the error message when failing to download kots binaries #4999

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67bf30d
improve the error message when failing to download kots binaries
laverya Nov 11, 2024
9fddaa7
Merge branch 'main' into laverya/improve-error-message-when-failing-t…
laverya Nov 11, 2024
7161805
Merge branch 'main' into laverya/improve-error-message-when-failing-t…
laverya Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/replicatedapp/embeddedcluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,15 @@ func DownloadKOTSBinary(license *kotsv1beta1.License, versionLabel string) (stri
defer resp.Body.Close()

if resp.StatusCode != 200 {
return "", errors.Errorf("unexpected status code %d", resp.StatusCode)
if resp.Body != nil {
body, err := io.ReadAll(resp.Body)
if err != nil {
return "", errors.Wrapf(err, "failed to read body following unexpected status code %d", resp.StatusCode)
}
return "", errors.Errorf("unexpected status code %d: %s", resp.StatusCode, body)
} else {
return "", errors.Errorf("unexpected status code %d", resp.StatusCode)
}
}

tmpFile, err := os.CreateTemp("", "kotsbin")
Expand Down
Loading