deploy app using kots run (first pass) #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
commented
Aug 24, 2021
sgalsaleh
commented
Aug 24, 2021
| @@ -20,7 +20,7 @@ spec: | |||
| constraints: | |||
| notNull: true | |||
| - name: updated_at | |||
| type: integer | |||
| type: timestamp | |||
There was a problem hiding this comment.
these were failing to be converted to time.Time in go. sqlite had a workaround for this by using the timestamp column type which will handle it internally.
There was a problem hiding this comment.
@divolgin ... thoughts on this?
There was a problem hiding this comment.
1st reference: mattn/go-sqlite3#748 (comment)
There was a problem hiding this comment.
2nd reference: mattn/go-sqlite3#190 (comment)
sgalsaleh
commented
Aug 24, 2021
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
this resulted in only having the first yaml document to be applied
sgalsaleh
commented
Aug 24, 2021
| @@ -160,6 +161,11 @@ func UpdateKotsadmIDConfigMap(kotsadmID string) error { | |||
| } | |||
|
|
|||
| func FindKotsadm(clientset *kubernetes.Clientset, namespace string) (string, error) { | |||
| if persistence.IsSQlite() { | |||
There was a problem hiding this comment.
TODO: need to have a separate function for detecting the kots run workflow so that this isn't confusing (applies to other occurrences as well)
sgalsaleh
changed the title
marccampbell
approved these changes
Aug 24, 2021
divolgin
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outstanding issues:
1- containerd doesn’t run because it can’t find runc in PATH
2- antrea falls back to using the in-cluster config. we need to point to the right kubeconfig file to use instead.