bug: bail out if no policycoreutils-python-utils #5363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bails the installation if the installer detects that we have selinux rules to apply but the underlying system does not provide us with the semanage command (policycoreutils-python-utils).
laverya
reviewed
Aug 26, 2024
| @@ -301,6 +301,12 @@ function apply_selinux_config() { | |||
| return | |||
| fi | |||
|
|
|||
| if is_amazon_2023 ; then | |||
There was a problem hiding this comment.
This package should be added to the deps list, not checked for here
laverya
approved these changes
Aug 26, 2024
ricardomaraschini
deleted the
ricardomaraschini/sc-106636/require-policycoreutils-python-utils-for-selinux-rules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
bails the installation if the installer detects that we have selinux rules to apply but the underlying system does not provide us with the semanage command (policycoreutils-python-utils).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?