use patches _correctly_ #4632
Merged
use patches _correctly_ #4632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4632-931606a-flannel-0.22.0-k8s-ctrd-2023-06-20T16:32:43Z |
rrpolanco
reviewed
Jun 20, 2023
| @@ -2,5 +2,5 @@ resources: | |||
| - kube-flannel.yml | |||
| - troubleshoot.yaml | |||
|
|
|||
| patches: | |||
| patchesStrategicMerge: | |||
There was a problem hiding this comment.
This won't work with kubernetes >= 1.27.x due to Kustomize v5 removing support for patchesStrategicMerge.
Instead you can do:
patches:
- path: kube-flannel-cfg.patch.yaml
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4632-c66ec25-flannel-0.22.0-k8s-ctrd-2023-06-22T14:56:52Z |
laverya
changed the title
ricardomaraschini
approved these changes
Jun 22, 2023
rrpolanco
approved these changes
Jun 22, 2023
laverya
added a commit
that referenced
this pull request
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?