Skip to content

Commit

Permalink
Merge pull request #889 from areed/configure-nameserver
Browse files Browse the repository at this point in the history
Add nameserver field to kurl installer spec
  • Loading branch information
areed authored Nov 12, 2020
2 parents aa5348b + e6d3abb commit 460564c
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
9 changes: 9 additions & 0 deletions kurlkinds/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
To make a change to the Installer type.

1. Edit ./pkg/apis/cluster/v1beta1/installer_types.go
1. Run `make generate`
1. Make a PR and merge.
1. cd to ../kurl_util
1. Run `go get github.com/replicatedhq/kurl/kurlkinds`
1. Define a new bash variable in kurl_util/cmd/yamltobash/main.go to hold the value of the new field.
1. Use the new bash variable in kurl install scripts.
2 changes: 2 additions & 0 deletions kurlkinds/config/crds/v1beta1/cluster.kurl.sh_installers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@ spec:
type: boolean
hostnameCheck:
type: string
nameserver:
type: string
noProxy:
type: boolean
privateAddress:
Expand Down
1 change: 1 addition & 0 deletions kurlkinds/pkg/apis/cluster/v1beta1/installer_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ type Kurl struct {
NoProxy bool `json:"noProxy,omitempty"`
PublicAddress string `json:"publicAddress,omitempty"`
PrivateAddress string `json:"privateAddress,omitempty"`
Nameserver string `json:"nameserver,omitempty"`
}

type Minio struct {
Expand Down

0 comments on commit 460564c

Please sign in to comment.