Implement EC install CLI command integration test #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
changed the title
emosbaugh
reviewed
Oct 29, 2024
sgalsaleh
force-pushed
the
salah/sc-113890/discovery-prioritize-two-highest-value-integration
branch
2 times, most recently
from
5399fc5
to
4235ad1
Compare
sgalsaleh
commented
Oct 30, 2024
emosbaugh
reviewed
Oct 30, 2024
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
emosbaugh
reviewed
Oct 31, 2024
tests/dryrun/util.go
Outdated
| } | ||
| } | ||
|
|
||
| func assertMetrics(t *testing.T, actual []dryruntypes.Metric, expected map[string]func(string)) { |
There was a problem hiding this comment.
expected maybe should be a slice so you can assert order
emosbaugh
reviewed
Oct 31, 2024
emosbaugh
reviewed
Oct 31, 2024
emosbaugh
reviewed
Oct 31, 2024
| //go:embed assets/install-release.yaml | ||
| var releaseData string | ||
|
|
||
| func dryrunInstall(t *testing.T, args ...string) dryruntypes.DryRun { |
There was a problem hiding this comment.
it would be nice to export functions that are intended to be used in testing to make this package more self documenting including this, readK0sConfig, and the assert functions
There was a problem hiding this comment.
this is only intended to be used for dryrun tests though
sgalsaleh
force-pushed
the
salah/sc-113890/discovery-prioritize-two-highest-value-integration
branch
from
e850f10
to
f7e31dc
Compare
emosbaugh
previously approved these changes
Oct 31, 2024
emosbaugh
previously approved these changes
Oct 31, 2024
sgalsaleh
force-pushed
the
salah/sc-113890/discovery-prioritize-two-highest-value-integration
branch
from
f3e2f09
to
d73f4b3
Compare
emosbaugh
approved these changes
Nov 1, 2024
sgalsaleh
deleted the
salah/sc-113890/discovery-prioritize-two-highest-value-integration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements a framework for running CLI dry run tests.
Which issue(s) this PR fixes:
SC-114608
Does this PR require a test?
Yes
Does this PR require a release note?
Does this PR require documentation?
NONE
Example output