Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate helm extensions in clusterconfig #1306

Conversation

emosbaugh
Copy link
Member

@emosbaugh emosbaugh commented Oct 9, 2024

What this PR does / why we need it:

Vendor provided helm extensions may be duplicated in the cluster config in some scenarios. For example in the bundle from this run.

https://github.com/replicatedhq/embedded-cluster/actions/runs/11076879363/job/30781413202?pr=1241

        - chartname: /var/lib/embedded-cluster/charts/ingress-nginx-4.8.3.tgz
          name: ingress-nginx
          namespace: ingress-nginx
          order: 110
          timeout: 0
          values: |
            controller:
              service:
                type: NodePort
                nodePorts:
                  http: "80"
                  https: "443"
              image:
                digest: ""
                digestChroot: ""
              admissionWebhooks:
                patch:
                  image:
                    digest: ""
          version: 4.8.3
        - chartname: /var/lib/embedded-cluster/charts/goldpinger-6.1.2.tgz
          name: goldpinger
          namespace: goldpinger
          order: 111
          timeout: 0
          values: ""
          version: 6.1.2
        - chartname: /var/lib/embedded-cluster/charts/ingress-nginx-4.8.3.tgz
          name: ingress-nginx
          namespace: ingress-nginx
          order: 110
          timeout: 0
          values: |
            controller:
              service:
                type: NodePort
                nodePorts:
                  http: "80"
                  https: "443"
              image:
                digest: ""
                digestChroot: ""
              admissionWebhooks:
                patch:
                  image:
                    digest: ""
          version: 4.8.3
        - chartname: /var/lib/embedded-cluster/charts/goldpinger-6.1.2.tgz
          name: goldpinger
          namespace: goldpinger
          order: 111
          timeout: 0
          values: ""
          version: 6.1.2

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?


Does this PR require documentation?

Copy link

github-actions bot commented Oct 9, 2024

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-e31e86f" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-e31e86f?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@emosbaugh emosbaugh force-pushed the emosbaugh/sc-113477/extensions-charts-are-duplicated-in-the-clusterconfig branch 2 times, most recently from e391020 to 0dfa070 Compare October 10, 2024 20:34
@emosbaugh emosbaugh changed the title DEBUG fix: duplicate helm extensions in clusterconfig Oct 10, 2024
@emosbaugh emosbaugh force-pushed the emosbaugh/sc-113477/extensions-charts-are-duplicated-in-the-clusterconfig branch from acf372b to dc08a41 Compare October 14, 2024 16:17
@laverya laverya marked this pull request as ready for review October 15, 2024 14:21
@emosbaugh emosbaugh merged commit 883aa95 into main Oct 15, 2024
57 checks passed
@emosbaugh emosbaugh deleted the emosbaugh/sc-113477/extensions-charts-are-duplicated-in-the-clusterconfig branch October 15, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants