Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: determine network interface / IP on join #1207

Merged

Conversation

sgalsaleh
Copy link
Member

@sgalsaleh sgalsaleh commented Sep 19, 2024

What this PR does / why we need it:

  • Automatically determines the network interfaces on join.
  • Fixes an issue where the internal node IP wasn't set from the user-specified network interface.

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?


Does this PR require documentation?

NONE

Copy link

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-3dc436a" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-3dc436a?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@sgalsaleh sgalsaleh marked this pull request as ready for review September 20, 2024 16:08
@sgalsaleh sgalsaleh merged commit acc9ea2 into main Sep 20, 2024
58 checks passed
@sgalsaleh sgalsaleh deleted the salah/sc-112094/let-users-select-their-preferred-interface-2 branch September 20, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants