-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ability to specify network interface #1204
Merged
sgalsaleh
merged 4 commits into
main
from
salah/sc-112094/let-users-select-their-preferred-interface
Sep 19, 2024
Merged
feat: ability to specify network interface #1204
sgalsaleh
merged 4 commits into
main
from
salah/sc-112094/let-users-select-their-preferred-interface
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
changed the title
Salah/sc 112094/let users select their preferred interface
feat: ability to specify network interface
Sep 19, 2024
laverya
reviewed
Sep 19, 2024
laverya
reviewed
Sep 19, 2024
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer:
Airgap Installer (may take a few minutes before the airgap bundle is built):
Happy debugging! |
laverya
reviewed
Sep 19, 2024
laverya
reviewed
Sep 19, 2024
laverya
approved these changes
Sep 19, 2024
Bypassing the |
sgalsaleh
deleted the
salah/sc-112094/let-users-select-their-preferred-interface
branch
September 19, 2024 19:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the ability to choose the network interface to use for the cluster node(s).
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?
TBD