Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to specify network interface #1204

Merged

Conversation

sgalsaleh
Copy link
Member

What this PR does / why we need it:

Adds the ability to choose the network interface to use for the cluster node(s).

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?

* Adds the ability to choose the network interface to use for the cluster node(s).

Does this PR require documentation?

TBD

@sgalsaleh sgalsaleh changed the title Salah/sc 112094/let users select their preferred interface feat: ability to specify network interface Sep 19, 2024
pkg/addons/applier.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 19, 2024

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-d0934f5" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-d0934f5?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

pkg/netutils/ips.go Outdated Show resolved Hide resolved
pkg/netutils/ips.go Outdated Show resolved Hide resolved
@sgalsaleh
Copy link
Member Author

Bypassing the TestSingleNodeAirgapUpgradeFromEC18 test failure as it's expected to be flakey until the upstream k0s fix is released.

@sgalsaleh sgalsaleh merged commit 41cda7e into main Sep 19, 2024
54 of 56 checks passed
@sgalsaleh sgalsaleh deleted the salah/sc-112094/let-users-select-their-preferred-interface branch September 19, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants