feat(preflights): include preflight collect results in support bundle #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laverya
reviewed
Sep 17, 2024
pkg/preflights/preflights.go
Outdated
| src = match | ||
| } | ||
| } | ||
| dst := filepath.Join(defaults.EmbeddedClusterLogsSubDir(), "preflight-bundle.tar.gz") |
There was a problem hiding this comment.
this shouldn't be unique - I think for logs we use the timestamp or something?
That way we don't overwrite each time the install command is run
There was a problem hiding this comment.
My thinking here is that if we store all these bundles here it will bloat the support bundle too much so i am only storing the latest.
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
banjoh
previously approved these changes
Sep 17, 2024
laverya
approved these changes
Sep 18, 2024
|
Test is flakey. Merging |
emosbaugh
deleted the
emosbaugh/sc-111576/include-host-preflight-results-in-support-bundle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The new version of troubleshoot will drop the preflight collected files on disk in the current directory. This change will move the file to the /var/lib/embedded-cluster/logs directory which is included in support bundles.
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?