Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if chart values parse as yaml before installing application #1194

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

laverya
Copy link
Member

@laverya laverya commented Sep 17, 2024

What this PR does / why we need it:

Sometimes additional chart values will be invalid yaml. This will prevent the installation from completing 5+ minutes later with very hard to debug error messages. We should check for this early.

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?

The 'install' command will check helm extension values for yaml validity before installation.

Does this PR require documentation?

Copy link

github-actions bot commented Sep 17, 2024

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-070059c" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-070059c?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@laverya laverya marked this pull request as ready for review September 17, 2024 20:41
@laverya laverya enabled auto-merge (squash) September 18, 2024 15:45
@laverya laverya merged commit 57ea942 into main Sep 18, 2024
56 checks passed
@laverya laverya deleted the laverya/check-for-valid-chart-yaml branch September 18, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants