automatically detect node ip during install for noproxy #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
This reverts commit 9479324.
sgalsaleh
reviewed
Sep 18, 2024
sgalsaleh
reviewed
Sep 18, 2024
sgalsaleh
reviewed
Sep 18, 2024
sgalsaleh
reviewed
Sep 18, 2024
sgalsaleh
reviewed
Sep 18, 2024
sgalsaleh
reviewed
Sep 18, 2024
sgalsaleh
reviewed
Sep 18, 2024
| return proxy | ||
| } | ||
|
|
||
| func combineNoProxySuppliedValuesAndDefaults(c *cli.Context, proxy *ecv1beta1.ProxySpec) { |
There was a problem hiding this comment.
name is too long 😆, but i guess it's fine. i would've gone with something like injectNoProxyDefaults or something.
Suggested change
| func combineNoProxySuppliedValuesAndDefaults(c *cli.Context, proxy *ecv1beta1.ProxySpec) { | |
| func combineNoProxySuppliedValuesAndDefaults(c *cli.Context, proxy *ecv1beta1.ProxySpec) { |
sgalsaleh
reviewed
Sep 18, 2024
| @@ -86,6 +86,7 @@ Additionally, it includes a Registry when deployed in air gap mode. | |||
| ``` | |||
|
|
|||
| 1. In the Vendor Portal, create and download a license that is assigned to the channel. | |||
| We recommend storing this license in the `local-dev/` directory, as it is gitignored and not otherwise used by the CI. | |||
There was a problem hiding this comment.
take it or leave it:
Suggested change
| We recommend storing this license in the `local-dev/` directory, as it is gitignored and not otherwise used by the CI. | |
| We recommend storing this license in the `local-dev/` directory that is dedicated to storing local development artifacts, as it is gitignored and not otherwise used by the CI. |
sgalsaleh
previously approved these changes
Sep 18, 2024
…IP is not covered
ajp-io
reviewed
Sep 18, 2024
Co-authored-by: Alex Parker <7272359+ajp-io@users.noreply.github.com>
sgalsaleh
approved these changes
Sep 19, 2024
laverya
deleted the
laverya/sc-111539/automatically-detect-node-ip-during-install
branch
sgalsaleh
restored the
laverya/sc-111539/automatically-detect-node-ip-during-install
branch
sgalsaleh
deleted the
laverya/sc-111539/automatically-detect-node-ip-during-install
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With no no-proxy set:
With an insufficient no-proxy set:
When joining a node that is not included in the cluster's no-proxy:
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?