Skip to content

Configure pylint and fix linter violations #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Oct 29, 2023
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7896847
Add workaround for setuptools bug
mattt Oct 29, 2023
83aa9ce
Extract setup step into script
mattt Oct 29, 2023
bdc79c9
Extract lint step into script
mattt Oct 29, 2023
0ff1258
Add script/format
mattt Oct 29, 2023
ee51121
Add pylint as optional dev dependency
mattt Oct 29, 2023
2372d43
Add pylint configuration to pyproject.toml
mattt Oct 29, 2023
8fc2dcf
Fix W4905: Using deprecated decorator abc.abstractproperty()
mattt Oct 29, 2023
63762f5
Fix W0719: Raising too general exception: Exception
mattt Oct 29, 2023
d049225
Fix W0621: Redefining name 'version' from outer scope (line 3)
mattt Oct 29, 2023
c503629
Fix E1101: Instance of 'ModelPrivateAttr' has no member
mattt Oct 29, 2023
c334577
Fix C0103: Name doesn't conform to snake_case naming style
mattt Oct 29, 2023
a922c27
Ignore C0103: Variable name doesn't conform to snake_case naming styl…
mattt Oct 29, 2023
bb6c526
Fix R1705: Unnecessary elif after return, remove the leading el from …
mattt Oct 29, 2023
d6ebe9f
Fix C0103: Constant name doesn't conform to UPPER_CASE naming style (…
mattt Oct 29, 2023
e92fa74
Fix C0103: Variable name doesn't conform to snake_case naming style (…
mattt Oct 29, 2023
eaf4747
Ignore R0911: Too many return statements (too-many-return-statements)
mattt Oct 29, 2023
3344a2a
Fix C0116: Missing function or method docstring (missing-function-doc…
mattt Oct 29, 2023
aa21664
Ignore C0116: Missing function or method docstring (missing-function-…
mattt Oct 29, 2023
18b7ad3
Fix C0115: Missing class docstring (missing-class-docstring)
mattt Oct 29, 2023
2a7e235
Run pylint in script/lint
mattt Oct 29, 2023
0266320
Extract test step into script
mattt Oct 29, 2023
b80a9d4
Run lint after test step
mattt Oct 29, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ignore C0103: Variable name doesn't conform to snake_case naming styl…
…e (invalid-name)

Signed-off-by: Mattt Zmuda <mattt@replicate.com>
  • Loading branch information
mattt committed Oct 29, 2023
commit a922c278af85f7f7dda7839ef09ca0d79f35862c
2 changes: 1 addition & 1 deletion replicate/base_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ def reload(self) -> None:
"""

new_model = self._collection.get(self.id) # pylint: disable=no-member
for k, v in new_model.dict().items():
for k, v in new_model.dict().items(): # pylint: disable=invalid-name
setattr(self, k, v)