Don't persist or send cookies to Replicate API #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickstenning
force-pushed
the
forget-all-cookies
branch
2 times, most recently
from
23d911c to
718006a
Compare
Replicate's API does not use cookies and even if we return cookies the client should not save and replay them. Co-authored-by: Mattt Zmuda <mattt@replicate.com> Signed-off-by: Nick Stenning <nick@whiteink.com> Signed-off-by: Mattt Zmuda <mattt@replicate.com>
mattt
approved these changes
May 19, 2023
There was a problem hiding this comment.
@nickstenning Thanks so much for contributing this. The implementation details for a requests session that doesn't persist cookies is trivial, so I decided to inline this functionality with a new, equivalent class instead of adding a new dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicate's API does not use cookies and even if we return cookies the client should not save and replay them.