add batch size metric #1750
Merged
add batch size metric #1750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: technillogue <technillogue@gmail.com>
technillogue
force-pushed
the
syl/add-batch-size-metric
branch
from
e6651fd to
311ac33
Compare
technillogue
added a commit
that referenced
this pull request
Jun 19, 2024
Signed-off-by: technillogue <technillogue@gmail.com>
technillogue
added a commit
that referenced
this pull request
Jun 19, 2024
Signed-off-by: technillogue <technillogue@gmail.com>
technillogue
added a commit
that referenced
this pull request
Jun 20, 2024
Signed-off-by: technillogue <technillogue@gmail.com>
technillogue
added a commit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: technillogue <technillogue@gmail.com>
technillogue
added a commit
that referenced
this pull request
Jul 18, 2024
Signed-off-by: technillogue <technillogue@gmail.com>
mattt
pushed a commit
that referenced
this pull request
Jul 18, 2024
Signed-off-by: technillogue <technillogue@gmail.com>
mattt
pushed a commit
that referenced
this pull request
Jul 19, 2024
Signed-off-by: technillogue <technillogue@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seemingly director or some other part of the system introduces enough change to predict_time as recorded in web that predict_time/predict_time_share gives implausible values for batch size. recording batch_size should be redundant given predict_time_share, but everything will probably be simpler to just record it explicitly.