Allow Any inputs
#1292
Closed
Allow Any inputs
#1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Gershenson <jgershen@users.noreply.github.com>
Signed-off-by: Joe Gershenson <jgershen@users.noreply.github.com>
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
|
Wahey! Passing tests! It's a shame that test was deleted in the other PR though. It should be testing the new behavior that it works. This PR is a bit of a mess now so I might try and make a clean version... |
|
So I tried the test that was deleted and turns out arbitrary input objects don't work because runner doesn't typecast objects, so this doesn't work all. I have written some tests to represent some of the behavior I really want from #608 in #1313, but I reckon this PR and #968 is the wrong approach so I reckon we can close them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #968