Skip to content

Add AsyncConcatenateIterator #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2025
Merged

Add AsyncConcatenateIterator #67

merged 3 commits into from
Apr 2, 2025

Conversation

@8W9aG
Copy link
Contributor

@8W9aG 8W9aG commented Apr 2, 2025

  • Add an AsyncConcatenateIterator to be on par with cogs interface

@8W9aG 8W9aG requested review from NikhilSinha1 and nevillelyh April 2, 2025 17:46
@8W9aG 8W9aG requested a review from a team as a code owner April 2, 2025 17:46
@nevillelyh
Copy link
Contributor

nevillelyh commented Apr 2, 2025 •
edited
Loading

We should fix this and maybe add one for async_concat_iterator? Similar to these 2:
https://github.com/replicate/cog-runtime/blob/main/python/tests/runners/async_iterator.py
https://github.com/replicate/cog-runtime/blob/main/python/tests/runners/concat_iterator.py

They are automatically "tested" with test_inputs BTW.
https://github.com/replicate/cog-runtime/blob/main/python/tests/test_test_inputs.py

@8W9aG 8W9aG merged commit 0b3a36b into main Apr 2, 2025
15 checks passed
@8W9aG 8W9aG deleted the sackfield/add-asynconcatenateiterator branch April 2, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikhilSinha1 NikhilSinha1 Awaiting requested review from NikhilSinha1

1 more reviewer

@nevillelyh nevillelyh nevillelyh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@8W9aG @nevillelyh