Skip to content

Convert COG_LOG_LEVEL=warning to use "warn" so zap can parse it #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Convert COG_LOG_LEVEL=warning to use "warn" so zap can parse it #210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1226a3a
Convert "warning" to "warn" so zap can parse it
michaeldwan Sep 12, 2025
ac9334e
Merge branch 'main' into md/tolerant-log-level-fix
michaeldwan Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions internal/util/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,12 @@ func HTTPClientWithRetry() *http.Client {
}

func CreateLogger(name string) *zap.Logger {
logLevel := os.Getenv("COG_LOG_LEVEL")
if logLevel == "" {
logLevel = "info"
logLevel := strings.ToUpper(os.Getenv("COG_LOG_LEVEL"))
switch logLevel {
case "WARNING":
logLevel = "WARN"
case "":
logLevel = "INFO"
}
Comment on lines +120 to 126
Copy link

Copilot AI Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The switch statement only handles uppercase values but converts all input to uppercase first. Consider adding a case for lowercase 'warning' or documenting that the ToUpper conversion handles case-insensitive matching.

Copilot uses AI. Check for mistakes.
lvl, err := zapcore.ParseLevel(logLevel)
if err != nil {
Expand Down
Loading