Repository navigation
Conversation
Heap contents differ between recording and replaying, so the snapshot
serializer already emits "{}" under record/replay, but the snapshot was
still generated first. On a big heap that is one native call long enough
for a replaying process to be considered hung. getHeapSnapshot()'s stream
also never ended, and worker.getHeapSnapshot() crashed on exit.
Fail every entry point before generating anything:
- v8.writeHeapSnapshot() and v8.getHeapSnapshot() throw
ERR_RECORD_REPLAY_UNSUPPORTED, and worker.getHeapSnapshot() rejects
with it.
- The --heapsnapshot-signal listener emits a warning instead, since
throwing from it would crash the process.
- --heapsnapshot-near-heap-limit doesn't install its callback and prints
a notice to stderr. It isn't a process warning because console messages
logged while bootstrapping crash replaying processes that collect
console messages.
- The inspector's HeapProfiler.takeHeapSnapshot and
stopTrackingHeapObjects return an error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heap contents differ between recording and replaying, so the snapshot serializer already emits "{}" under record/replay, but the snapshot was still generated first. On a big heap that is one native call long enough for a replaying process to be considered hung. getHeapSnapshot()'s stream also never ended, and worker.getHeapSnapshot() crashed on exit.
Fail every entry point before generating anything: