instrument the build with honeycomb buildevents #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshok
force-pushed
the
toshok/buildevents
branch
5 times, most recently
from
0daa536 to
e52e355
Compare
toshok
force-pushed
the
toshok/buildevents
branch
5 times, most recently
from
12e2681 to
86d32de
Compare
![replay-soc2[bot]](https://avatars.githubusercontent.com/u/60818315?s=60&v=4){kind=small}
toshok
force-pushed
the
toshok/buildevents
branch
2 times, most recently
from
7c488f9 to
0e18cbe
Compare
toshok
force-pushed
the
toshok/buildevents
branch
from
0e18cbe to
e31da0a
Compare
toshok
changed the title
|
Oh nvm I didn't look at the plugin. |
|
oh yeah, I would also totally love some 👀 /opinions/bikeshedding on how things are done in the buildkite plugin. was mostly riffing off what I'd seen elsewhere, and things like |
|
@toshok the plugin looks good to me but my bash knowledge is at like a 5th grade level 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on a fork of the honeycomb buildevents repo here (which adds a buildkite-specific version of the
watchcommand.) and the buildkite plugin here.No windows support yet (the ssm plugin has windows issues as well, but there are hamfisted batch files in the buildkite plugin) so those steps aren't instrumented.
Likewise the runtime e2e in the backend aren't instrumented currently, but there's a corresponding backend PR for that https://github.com/replayio/backend/pull/9038.
Both of those gaps in instrumentation are visible in build traces as .. big unexplained gaps in the root span.