fix: prevent authConnector from being included in wagmi config when email/social login are disabled
#4892
Conversation
🦋 Changeset detectedLatest commit: f6d372f The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the authConnector was incorrectly being included in the wagmi configuration even when both email and social login features were disabled. The fix ensures that the connector is only added when at least one of these authentication methods is enabled.
Key changes:
- Switch from using
remoteFeaturestofeaturesfor checking authentication settings - Add proper tracking of features in the base client
- Update tests to reflect the new feature checking approach
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/appkit/src/client/appkit-base-client.ts | Adds features property initialization to track local feature settings |
| packages/adapters/wagmi/src/client.ts | Updates auth connector logic to use local features instead of remote features and fixes EIP6963 option check |
| packages/adapters/wagmi/src/tests/client.test.ts | Updates test suite to use features instead of remoteFeatures and adds async/await patterns |
| .changeset/poor-papers-cry.md | Documents the bug fix in the changeset |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Description
Fixed an issue where
authConnectorwas always included in wagmi config when email and social login were disabledType of change
Associated Issues
For Linear issues: Closes APKT-3641
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist