chore: upgrade valtio to v2 #4358

enesozturk · 2025-05-16T08:13:20Z

Description

Upgrades Valtio to v2. Valtio v2 is compatible with v1. Only difference is that we should be wrapping values with ref if they are non plain objects. In this PR, it's updating some pages in laboratory to use AppKitProvider and updates ThemeStore and AppKitStore to use ref()

Type of change

Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-3151
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

Code in this PR is covered by automated tests (Unit tests, E2E tests)
My changes generate no new warnings
I have reviewed my own code
I have filled out all required sections
I have tested my changes on the preview link
Approver of this PR confirms that the changes are tested on the preview link

vercel · 2025-05-16T08:13:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
appkit-basic-html	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 2, 2025 10:26am
appkit-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 2, 2025 10:26am
appkit-laboratory	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 2, 2025 10:26am

11 Skipped Deployments

Name	Status	Preview	Updated (UTC)
appkit-basic-ep	⬜️ Ignored (Inspect)		Jul 2, 2025 10:26am
appkit-basic-example	⬜️ Ignored (Inspect)		Jul 2, 2025 10:26am
appkit-basic-sign-client-example	⬜️ Ignored (Inspect)		Jul 2, 2025 10:26am
appkit-basic-up-example	⬜️ Ignored (Inspect)	Visit Preview	Jul 2, 2025 10:26am
appkit-ethers5-bera	⬜️ Ignored (Inspect)		Jul 2, 2025 10:26am
appkit-nansen-demo	⬜️ Ignored (Inspect)		Jul 2, 2025 10:26am
appkit-vue-solana	⬜️ Ignored (Inspect)		Jul 2, 2025 10:26am
appkit-wagmi-cdn-example	⬜️ Ignored (Inspect)		Jul 2, 2025 10:26am
ethereum-provider-wagmi-example	⬜️ Ignored (Inspect)		Jul 2, 2025 10:26am
next-wagmi-solana-bitcoin-example	⬜️ Ignored (Inspect)		Jul 2, 2025 10:26am
vue-wagmi-example	⬜️ Ignored (Inspect)		Jul 2, 2025 10:26am

socket-security · 2025-05-16T08:17:02Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	esbuild@0.25.5
	postcss@8.5.3
	react@19.1.0
	typescript@5.8.3
	react-dom@19.1.0

View full report

github-actions · 2025-05-16T08:17:44Z

	Warnings
⚠️	🔑 Potential High‑entropy string detected in packages/experimental/package.json (line 25): `dist/types/exports/e...`
⚠️	🔑 Potential High‑entropy string detected in packages/experimental/package.json (line 25): `dist/types/exports/e...`
⚠️	🔑 Potential High‑entropy string detected in packages/appkit/package.json (line 39): `dist/types/exports/l...`
⚠️	🔑 Potential High‑entropy string detected in packages/appkit/package.json (line 39): `dist/types/exports/l...`

Generated by 🚫 dangerJS against 30f9b41

github-actions · 2025-05-16T08:19:53Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	77.85%	30845 / 39621
🔵	Statements	77.85%	30845 / 39621
🔵	Functions	68.77%	2539 / 3692
🔵	Branches	84.4%	6404 / 7587

File Coverage

No changed files found.

Generated in workflow #13104 for commit 30f9b41 by the Vitest Coverage Report Action

changeset-bot · 2025-05-16T11:29:17Z

🦋 Changeset detected

Latest commit: 30f9b41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages

Name	Type
@reown/appkit-adapter-ethers5	Patch
@reown/appkit-adapter-ethers	Patch
@reown/appkit-adapter-solana	Patch
@reown/appkit-adapter-wagmi	Patch
@reown/appkit-wallet-button	Patch
@reown/appkit-utils	Patch
@reown/appkit-experimental	Patch
@reown/appkit-controllers	Patch
@reown/appkit	Patch
@reown/appkit-siwe	Patch
@reown/appkit-pay	Patch
@reown/appkit-adapter-bitcoin	Patch
@reown/appkit-cdn	Patch
@reown/appkit-cli	Patch
@reown/appkit-codemod	Patch
@reown/appkit-common	Patch
@reown/appkit-core	Patch
@reown/appkit-polyfills	Patch
@reown/appkit-scaffold-ui	Patch
@reown/appkit-siwx	Patch
@reown/appkit-testing	Patch
@reown/appkit-ui	Patch
@reown/appkit-wallet	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/appkit/tests/client/initialization.test.ts

linear · 2025-07-01T12:39:41Z

APKT-3151 Switch AppKit to Valtio v2

cursor

Bug: Missing Project ID in Config Causes Initialization Failures

The projectId: ConstantsUtil.ProjectId property was accidentally omitted from the config object during the refactoring from createAppKit to AppKitProvider. As projectId is a required AppKit configuration property, its absence will cause initialization failures and runtime errors. Other similar files in this commit correctly retain the projectId.

apps/laboratory/app/library/multichain-ethers5-solana/page.tsx#L28-L36

appkit/apps/laboratory/app/library/multichain-ethers5-solana/page.tsx

Lines 28 to 36 in 30f9b41

    
           const config = { 
        
             adapters: [etherAdapter, solanaWeb3JsAdapter], 
        
             networks, 
        
             defaultNetwork: mainnet, 
        
             customWallets: ConstantsUtil.CustomWallets, 
        
             termsConditionsUrl: 'https://reown.com/terms-of-service', 
        
             privacyPolicyUrl: 'https://reown.com/privacy-policy' 
        
           }

Fix in Cursor

Was this report helpful? Give feedback by reacting with 👍 or 👎

lukaisailovic · 2025-07-02T10:30:11Z

@enesozturk Are we exposing valtio state somewhere publicly? We shouldn't do it directly, but if we do, do the customers need to use ref then?

enesozturk · 2025-07-02T11:05:39Z

@enesozturk Are we exposing valtio state somewhere publicly? We shouldn't do it directly, but if we do, do the customers need to use ref then?

We are exposing state only via hooks and plain JS functions, but the using ref() only matter when you create state/proxy - so users won't get any issues using the exposed values

vercel bot deployed to Preview – appkit-demo May 16, 2025 08:20 View deployment

vercel bot deployed to Preview – appkit-laboratory May 16, 2025 08:21 View deployment

vercel bot had a problem deploying to Preview – appkit-laboratory May 16, 2025 11:29 Failure

vercel bot had a problem deploying to Preview – appkit-demo May 16, 2025 11:29 Failure

enesozturk changed the title ~~chore: upgrade valtio to v2~~ [DO NOT MERGE] chore: upgrade valtio to v2 May 16, 2025

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – appkit-basic-html June 30, 2025 10:10 View deployment

vercel bot deployed to Preview – appkit-demo June 30, 2025 10:14 View deployment

vercel bot deployed to Preview – appkit-basic-html June 30, 2025 10:16 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – appkit-demo June 30, 2025 10:18 View deployment

vercel bot deployed to Preview – appkit-laboratory June 30, 2025 10:18 View deployment

enesozturk mentioned this pull request Jun 30, 2025

[DO NOT MERGE] chore: upgrade appkit to valtio v2 canary WalletConnect/walletconnect-monorepo#6790

Open

15 tasks

vercel bot deployed to Preview – appkit-basic-html June 30, 2025 13:40 View deployment

vercel bot deployed to Preview – appkit-demo June 30, 2025 13:42 View deployment

vercel bot deployed to Preview – appkit-laboratory June 30, 2025 13:44 View deployment

vercel bot had a problem deploying to Preview – appkit-demo June 30, 2025 13:55 Failure

vercel bot had a problem deploying to Preview – appkit-basic-html June 30, 2025 13:55 Failure

vercel bot had a problem deploying to Preview – appkit-laboratory June 30, 2025 13:55 Failure

vercel bot deployed to Preview – appkit-basic-html June 30, 2025 13:59 View deployment

vercel bot deployed to Preview – appkit-demo June 30, 2025 14:02 View deployment

vercel bot deployed to Preview – appkit-laboratory June 30, 2025 14:03 View deployment

chore: upgrade valtio to v2

d9a38d4

enesozturk force-pushed the chore/upgrace-valtio-to-v2 branch from f97d434 to d9a38d4 Compare June 30, 2025 16:31

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – appkit-basic-html June 30, 2025 20:37 View deployment

vercel bot deployed to Preview – appkit-demo June 30, 2025 20:39 View deployment

vercel bot deployed to Preview – appkit-laboratory June 30, 2025 20:41 View deployment

enesozturk changed the title ~~[DO NOT MERGE] chore: upgrade valtio to v2~~ chore: upgrade valtio to v2 Jul 1, 2025

enesozturk commented Jul 1, 2025

View reviewed changes

packages/appkit/tests/client/initialization.test.ts Show resolved Hide resolved

chore: changeset file

41e16b1

enesozturk requested a review from a team July 1, 2025 12:24

Merge branch 'main' into chore/upgrace-valtio-to-v2

612b69e

vercel bot deployed to Preview – appkit-basic-html July 1, 2025 12:25 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview – appkit-demo July 1, 2025 12:32 View deployment

vercel bot deployed to Preview – appkit-basic-html July 1, 2025 12:32 View deployment

vercel bot deployed to Preview – appkit-laboratory July 1, 2025 12:34 View deployment

Merge branch 'main' into chore/upgrace-valtio-to-v2

30f9b41

cursor bot reviewed Jul 2, 2025

View reviewed changes

vercel bot deployed to Preview – appkit-basic-html July 2, 2025 10:23 View deployment

vercel bot deployed to Preview – appkit-demo July 2, 2025 10:26 View deployment

vercel bot deployed to Preview – appkit-laboratory July 2, 2025 10:26 View deployment

lukaisailovic approved these changes Jul 2, 2025

View reviewed changes

enesozturk enabled auto-merge July 2, 2025 11:05

enesozturk added this pull request to the merge queue Jul 2, 2025

Merged via the queue into main with commit f76135f Jul 2, 2025
41 checks passed

enesozturk deleted the chore/upgrace-valtio-to-v2 branch July 2, 2025 11:35

This was referenced Jul 2, 2025

chore: version packages #4599

Merged

chore: version packages leopardracer/appkit#1

Open


	const config = {
	adapters: [etherAdapter, solanaWeb3JsAdapter],
	networks,
	defaultNetwork: mainnet,
	customWallets: ConstantsUtil.CustomWallets,
	termsConditionsUrl: 'https://reown.com/terms-of-service',
	privacyPolicyUrl: 'https://reown.com/privacy-policy'
	}

chore: upgrade valtio to v2 #4358

chore: upgrade valtio to v2 #4358

Uh oh!

Conversation

enesozturk commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Associated Issues

Showcase (Optional)

Checklist

Uh oh!

vercel bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

changeset-bot bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

linear bot commented Jul 1, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Missing Project ID in Config Causes Initialization Failures

Uh oh!

lukaisailovic commented Jul 2, 2025

Uh oh!

enesozturk commented Jul 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

enesozturk commented May 16, 2025 •

edited

Loading

vercel bot commented May 16, 2025 •

edited

Loading

socket-security bot commented May 16, 2025 •

edited

Loading

github-actions bot commented May 16, 2025 •

edited

Loading

github-actions bot commented May 16, 2025 •

edited

Loading

changeset-bot bot commented May 16, 2025 •

edited

Loading