Take ACCESS EXCLUSIVE LOCK carefully #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@za-arthur Please rebase and run GitHub Actions checks. |
Try to get the lock in loop with timeouts using `lock_exclusive()`. This allows to not stuck lock queue for readers if pg_repack cannot take the lock fast enough.
za-arthur
force-pushed
the
reorg-lock-carefully
branch
from
59e30c7
to
1e2f9b4
Compare
|
@andreasscherbaum I rebased the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to get the lock in loop with timeouts using
lock_exclusive(). This allows to not stuck lock queue for readers if pg_repack cannot take the lock fast enough.We had incidents when cleanup functions, which run
repack.repack_drop(), couldn't get ACCESS EXCLUSIVE lock in a reasonable time. It was because there was long running write connections, running around 5-10 minutes.repack.repack_drop()also stucks lock queue block any new readers until all old writes finish.