Refactoring, remove useless code, creating tests

.github/workflows/ci.yml

@@ -67,6 +67,15 @@ jobs:
           retention-days: 14 # Keep artifacts for 14 days
           if-no-files-found: error # Fail the workflow if no JARs are found
 
+      # Upload BungeeCord JAR as an artifact
+      - name: Upload BungeeCord JAR Artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: serverpulse-bungeecord-jar
+          path: bungeecord/build/libs/serverpulse-*.jar
+          retention-days: 14
+          if-no-files-found: error # Fail the workflow if no JARs are found
+
       # --- Infrastructure Testing ---
 
       # 4. Install jq (needed for parsing InfluxDB health check JSON)

api/src/main/java/it/renvins/serverpulse/api/data/AsyncMetricsSnapshot.java

@@ -1,5 +1,6 @@
 package it.renvins.serverpulse.api.data;
 
+
 public class AsyncMetricsSnapshot {
 
     private final long usedHeap;
@@ -25,30 +26,65 @@ public AsyncMetricsSnapshot(long usedHeap, long commitedHeap, long totalDisk, lo
         this.avgPing = avgPing;
     }
 
+    /**
+     * Gets the amount of used heap memory in bytes.
+     *
+     * @return the used heap memory
+     */
     public long getUsedHeap() {
         return usedHeap;
     }
 
+    /**
+     * Gets the amount of committed heap memory in bytes.
+     *
+     * @return the committed heap memory
+     */
     public long getCommitedHeap() {
         return commitedHeap;
     }
 
+    /**
+     * Gets the total disk space available in bytes.
+     *
+     * @return the total disk space
+     */
     public long getTotalDisk() {
         return totalDisk;
     }
 
+    /**
+     * Gets the usable disk space available in bytes.
+     *
+     * @return the usable disk space
+     */
     public long getUsableDisk() {
         return usableDisk;
     }
 
+    /**
+     * Gets the minimum ping recorded in milliseconds.
+     *
+     * @return the minimum ping
+     */
     public long getMinPing() {
         return minPing;
     }
 
+    /**
+     * Gets the maximum ping recorded in milliseconds.
+     *
+     * @return the maximum ping
+     */
     public long getMaxPing() {
         return maxPing;
     }
 
+    /**
+     * Gets the average ping recorded in milliseconds.
+     *
+     * @return the average ping
+     */
     public long getAvgPing() {
         return avgPing;
     }

api/src/main/java/it/renvins/serverpulse/api/data/SyncMetricsSnapshot.java

@@ -2,7 +2,6 @@
 
 import java.util.Map;
 
-
 public class SyncMetricsSnapshot {
 
     private final double[] tps;

build.gradle.kts

@@ -1,5 +1,5 @@
 group = "it.renvins"
-version = "0.4.2-SNAPSHOT"
+version = "0.4.5-SNAPSHOT"
 
 repositories {
     mavenCentral()

bukkit/build.gradle.kts

@@ -14,13 +14,15 @@ repositories {
         name = "papermc"
         url = uri("https://repo.papermc.io/repository/maven-public/")
     }
+    maven { url = uri("https://jitpack.io") }
 }
 
 dependencies {
     implementation(project(":api"))
     implementation(project(":common"))
 
     compileOnly("io.papermc.paper:paper-api:1.21.7-R0.1-SNAPSHOT")
+    compileOnly("com.github.Carleslc.Simple-YAML:Simple-Yaml:1.8.4")
 }
 
 java {
@@ -31,6 +33,9 @@ tasks.withType<ShadowJar> {
     archiveBaseName = "serverpulse"
     archiveClassifier = "bukkit"
     archiveVersion = "${rootProject.version}"
+    duplicatesStrategy = DuplicatesStrategy.EXCLUDE
+
+    minimize()
 }
 
 tasks.withType<ProcessResources> {

bukkit/src/main/java/it/renvins/serverpulse/bukkit/ServerPulseBukkitLoader.java

@@ -12,14 +12,10 @@
 import it.renvins.serverpulse.bukkit.logger.BukkitLogger;
 import it.renvins.serverpulse.bukkit.metrics.BukkitTPSRetriever;
 import it.renvins.serverpulse.common.DatabaseService;
-import it.renvins.serverpulse.common.config.DatabaseConfiguration;
-import it.renvins.serverpulse.common.config.MetricsConfiguration;
+import it.renvins.serverpulse.common.config.GeneralConfiguration;
 import it.renvins.serverpulse.bukkit.commands.ServerPulseCommand;
-import it.renvins.serverpulse.bukkit.config.BukkitConfiguration;
 import it.renvins.serverpulse.common.logger.PulseLogger;
 import it.renvins.serverpulse.common.disk.DiskRetriever;
-import it.renvins.serverpulse.bukkit.config.BukkitDatabaseConfiguration;
-import it.renvins.serverpulse.bukkit.config.BukkitMetricsConfiguration;
 import it.renvins.serverpulse.bukkit.metrics.BukkitPingRetriever;
 import it.renvins.serverpulse.bukkit.metrics.PaperTPSRetriever;
 import it.renvins.serverpulse.bukkit.platform.BukkitPlatform;
@@ -35,7 +31,7 @@ public class ServerPulseBukkitLoader implements Service {
     private final ServerPulseBukkit plugin;
     public static Logger LOGGER;
 
-    private final BukkitConfiguration config;
+    private final GeneralConfiguration config;
 
     private final Platform platform;
 
@@ -51,17 +47,14 @@ public ServerPulseBukkitLoader(ServerPulseBukkit plugin) {
         this.plugin = plugin;
         LOGGER = plugin.getLogger();
 
-        this.config = new BukkitConfiguration(plugin, "config.yml");
-
         PulseLogger logger = new BukkitLogger(LOGGER);
 
+        this.config = new GeneralConfiguration(logger, plugin.getDataFolder(), "config.yml");
+
         this.platform = new BukkitPlatform(plugin);
         TaskScheduler taskScheduler = new BukkitTaskScheduler(plugin);
 
-        DatabaseConfiguration databaseConfiguration = new BukkitDatabaseConfiguration(config);
-        MetricsConfiguration metricsConfiguration = new BukkitMetricsConfiguration(config);
-
-        this.databaseService = new DatabaseService(logger, platform, databaseConfiguration, taskScheduler);
+        this.databaseService = new DatabaseService(logger, platform, config, taskScheduler);
 
         if (isPaper()) {
             this.tpsRetriever = new PaperTPSRetriever();
@@ -72,7 +65,7 @@ public ServerPulseBukkitLoader(ServerPulseBukkit plugin) {
         this.pingRetriever = new BukkitPingRetriever();
 
         MetricsCollector collector = new MetricsCollector(logger, platform, tpsRetriever, diskRetriever, pingRetriever);
-        LineProtocolFormatter formatter = new LineProtocolFormatter(metricsConfiguration);
+        LineProtocolFormatter formatter = new LineProtocolFormatter(config);
 
         this.metricsService = new MetricsService(logger, collector, formatter, taskScheduler, databaseService);
 

bukkit/src/main/java/it/renvins/serverpulse/bukkit/commands/ReloadCommand.java

@@ -1,14 +1,14 @@
 package it.renvins.serverpulse.bukkit.commands;
 
+import it.renvins.serverpulse.common.config.GeneralConfiguration;
 import it.renvins.serverpulse.common.utils.ChatUtils;
-import it.renvins.serverpulse.bukkit.config.BukkitConfiguration;
 import org.bukkit.command.CommandSender;
 
 public class ReloadCommand extends GeneralCommand {
 
-    private final BukkitConfiguration config;
+    private final GeneralConfiguration config;
 
-    public ReloadCommand(String permission, boolean isPlayerOnly, BukkitConfiguration config) {
+    public ReloadCommand(String permission, boolean isPlayerOnly, GeneralConfiguration config) {
         super(permission, isPlayerOnly);
         this.config = config;
     }
@@ -19,7 +19,7 @@ public void run(CommandSender sender, String[] args) {
             sender.sendMessage(ChatUtils.format(config.getConfig().getString("messages.reloadConfigUsage")));
             return;
         }
-        if (!config.reload()) {
+        if (!config.load()) {
             sender.sendMessage(ChatUtils.format(config.getConfig().getString("messages.reloadConfigError")));
         } else {
             sender.sendMessage(ChatUtils.format(config.getConfig().getString("messages.reloadConfig")));

bukkit/src/main/java/it/renvins/serverpulse/bukkit/commands/ServerPulseCommand.java

@@ -3,19 +3,19 @@
 import java.util.HashMap;
 import java.util.Map;
 
+import it.renvins.serverpulse.common.config.GeneralConfiguration;
 import it.renvins.serverpulse.common.utils.ChatUtils;
-import it.renvins.serverpulse.bukkit.config.BukkitConfiguration;
 import org.bukkit.command.Command;
 import org.bukkit.command.CommandExecutor;
 import org.bukkit.command.CommandSender;
 import org.jetbrains.annotations.NotNull;
 
 public class ServerPulseCommand implements CommandExecutor {
 
-    private final BukkitConfiguration config;
+    private final GeneralConfiguration config;
     private final Map<String, GeneralCommand> commands = new HashMap<>();
 
-    public ServerPulseCommand(BukkitConfiguration config) {
+    public ServerPulseCommand(GeneralConfiguration config) {
         this.config = config;
         registerCommands();
     }

bukkit/src/main/java/it/renvins/serverpulse/bukkit/commands/StatusCommand.java

@@ -1,15 +1,15 @@
 package it.renvins.serverpulse.bukkit.commands;
 
 import it.renvins.serverpulse.api.ServerPulseProvider;
+import it.renvins.serverpulse.common.config.GeneralConfiguration;
 import it.renvins.serverpulse.common.utils.ChatUtils;
-import it.renvins.serverpulse.bukkit.config.BukkitConfiguration;
 import org.bukkit.command.CommandSender;
 
 public class StatusCommand extends GeneralCommand {
 
-    private final BukkitConfiguration config;
+    private final GeneralConfiguration config;
 
-    public StatusCommand(String permission, boolean isPlayerOnly, BukkitConfiguration config) {
+    public StatusCommand(String permission, boolean isPlayerOnly, GeneralConfiguration config) {
         super(permission, isPlayerOnly);
 
         this.config = config;