Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for URI and UUID attribute types #370

Merged

Conversation

protocool
Copy link
Contributor

Summary of Changes

This adds support for generating accessors for NSURIAttributeType and NSUUIDAttributeType attributes, which were introduced in iOS 11 and macOS 10.13.

With the introduction of this change, the mogenerator binary must be built using Xcode 9.

@protocool
Copy link
Contributor Author

WRT the CI failure, that may be the result of my changing test/Rakefile to query for the latest SDK instead of using a hard-coded path to the 10.12 SDK.

I can amend to point to the relevant path for the CI server, just let me know.

@rentzsch
Copy link
Owner

Hey Trevor,

Thanks for the Pull Request!

I do prefer the explicitness of specifying the entire hard-coded path in the Rakefile's OSX_SDK.

Also, you probably have to update the osx_image in .travis.yml to xcode9 to get CI to pass (assuming Travis already has and supports Xcode 9).

@protocool
Copy link
Contributor Author

Hey. I've restored the specific path (to 10.13 SDK) and, as you suspected, it was trivial to update the travis config to use Xcode 9.

Let me know if there are any other concerns.

@tomekc
Copy link
Contributor

tomekc commented Jun 20, 2018

So... will this PR be pulled or stay forever here...? :)

Edit: never mind, I integrated in with my fork. ;-)

@atomicbird atomicbird merged commit cc1304a into rentzsch:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants