Add support for Binance Chain #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
susruth
commented
Sep 12, 2019
susruth
commented
- This PR adds Binance Chain support to the Mercury SDK
tok-kkk
reviewed
Sep 19, 2019
types/bnctypes/address.go
Outdated
| } | ||
|
|
||
| func AddressFromBech32(address string, network Network) (Address, error) { | ||
| types.Network = network.ChainNetwork() |
There was a problem hiding this comment.
This is dangerous to change the global variable of the package. Maybe reimplement the function here along with the type you need.
tok-kkk
requested changes
Sep 19, 2019
| } | ||
|
|
||
| func (bncTx *bncTx) Hash() types.TxHash { | ||
| panic("unimplemented") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.