Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hardcode label missing issue number #34381

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • Hardcode the labels missing issue

Context

  • The command used to check for issue tries to fetch all issues and then check for the label missing issue based on title.this can fail as the gh cli by default only returns last 30 issues
  • Another solution is to use the command to look for issue based on author and title which shuold be a good fix, but since we already have the issue we could also just hardcodeit

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

- gh cli returns to 30 issues as default, but we know it will exists so we can just hardcode it
@rarkins rarkins added this pull request to the merge queue Feb 22, 2025
Merged via the queue into renovatebot:main with commit c1c1ce1 Feb 22, 2025
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.177.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants