Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bazel-module): do not rely on fragments to test rules #34298

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Feb 19, 2025

Changes

Instead of using fragments (the parser intermediate representation), we directly use code blocks which we feed to the parser first.

Context

This makes the tests independent of the specific intermediate representation we use for parsing. As such, they are:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

gzm0 added 2 commits February 19, 2025 06:33
This makes the tests independent of the specific intermediate
representation we use for parsing. As such, they are:

- Easier to understand (they directly map bazel concepts to Renovate
  concepts)
- More robust to changes to the parser (like renovatebot#34154).
@rarkins rarkins added this pull request to the merge queue Feb 20, 2025
Merged via the queue into renovatebot:main with commit 14fd37f Feb 20, 2025
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.176.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants