Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Haskell (Cabal) support #31434

Closed
wants to merge 2 commits into from

Conversation

ysangkok
Copy link

Changes

  • Adds a Hackage datasource to allow fetching releases Haskell packages on Hackage
  • Adds a Cabal file parser, to allow extracting dependencies from .cabal files
  • Adds a same-major-pvp variant, which is like same-major, but for PVP (where the B in A.B.C is also part of the major version)

Context

This is related to #8187, but the discussion talks mostly about dependencies
pinned with Git commits. This PR is about bumping version bounds of packages
released to Hackage.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

Since this is a new feature, I think it would make most sense to add it to documentation later.

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@ysangkok ysangkok changed the title Add Haskell (Cabal) support feat: Add Haskell (Cabal) support Sep 17, 2024
@secustor
Copy link
Collaborator

This needs a discussion first for the manager part and should be split up into separate PRs:

  1. versioning
  2. datasource
  3. manager

@secustor secustor added the auto:discussion-first This PR needs to be preceded by a GitHub Discussion label Sep 19, 2024
Copy link
Contributor

Please create a GitHub Discussion before continuing with this PR.

Thank you for your PR, but we need to discuss the requirements and implementation first.

The maintainers believe that there is a lack of - or misalignment of - requirements about this PR. We need to discuss the requirements and implementation first so that you don't write code that won't be merged.

This PR will be closed for now to avoid confusion, but you can reopen it after the discussion has been resolved.

Thanks, the Renovate team

@github-actions github-actions bot closed this Sep 19, 2024
@ysangkok ysangkok deleted the haskell-pvp branch October 19, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:discussion-first This PR needs to be preceded by a GitHub Discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants