Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/gleam): enable update-lockfile #31002

Merged

Conversation

SnakeDoc
Copy link
Contributor

@SnakeDoc SnakeDoc commented Aug 25, 2024

Changes

Enables lockfile updates

This should not be merged until #31000 is accepted.
#31000 has been merged, we can proceed with this PR.

Context

Supersedes #30811

The Gleam manager does not allow rangeStrategy=update-lockfile

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems there is a command merged upstream and this PR now needs an update too.

@SnakeDoc
Copy link
Contributor Author

Yes! Great news, Gleam v1.6.0 landed this feature as a result of gleam-lang/gleam#3602. Gleam v1.6.1 (released today) includes a hotfix that stabilizes this new feature - so we should be good to proceed!

I have a staged changeset on my development branch that I will test tonight. If everything looks good, I'll update this PR and ping it for a fresh review.

@SnakeDoc SnakeDoc force-pushed the feat/gleam-enable-update-locked branch from 2611eda to c71a474 Compare November 20, 2024 04:51
@SnakeDoc SnakeDoc requested a review from viceice November 20, 2024 04:55
@SnakeDoc
Copy link
Contributor Author

I never know when to trust GH's notifications! Forgive me if this is already in your queue @viceice

@SnakeDoc SnakeDoc requested a review from rarkins November 26, 2024 19:15
@SnakeDoc
Copy link
Contributor Author

SnakeDoc commented Dec 5, 2024

I'm wondering if there's something wrong with this PR, or if everyone is just very busy this time of year? If something is not up to standards, please let me know so I can address it. 🚀

@rarkins rarkins requested a review from secustor December 6, 2024 09:26
@rarkins rarkins added this pull request to the merge queue Dec 6, 2024
Merged via the queue into renovatebot:main with commit d29698e Dec 6, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.53.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SnakeDoc SnakeDoc deleted the feat/gleam-enable-update-locked branch December 6, 2024 17:59
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups, forgot to send my review

lib/modules/manager/gleam/artifacts.ts Show resolved Hide resolved
@SnakeDoc SnakeDoc restored the feat/gleam-enable-update-locked branch December 6, 2024 21:24
@SnakeDoc SnakeDoc deleted the feat/gleam-enable-update-locked branch December 7, 2024 06:34
SnakeDoc added a commit to fluximus-prime/renovate that referenced this pull request Dec 7, 2024
@SnakeDoc
Copy link
Contributor Author

SnakeDoc commented Dec 7, 2024

Thanks everyone for your help on this PR, and for your patience. It was a long journey, but we made it!

Super eager to get this out into the wild! 🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants