Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): Add nenoNaninu/TypedSignalR.Client #27396

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

sommmen
Copy link
Contributor

@sommmen sommmen commented Feb 18, 2024

Changes

Adds https://github.com/nenoNaninu/TypedSignalR.Client

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these repos all release synchronized versions at the same time?

viceice
viceice previously approved these changes Feb 19, 2024
@sommmen
Copy link
Contributor Author

sommmen commented Feb 19, 2024

Do these repos all release synchronized versions at the same time?

I'm not sure exactly what you're asking - but i don't think so. As in, if packages in the main repo are updated, this does not automatically mean a release of .DevTools and/or .Typescript, the author seems to keep things seperate in that regard. I can imagine if there are breaking changes all packages of all git repos would be updated.

Would you like me to remove those and then simply refer to the main repo?

@rarkins
Copy link
Collaborator

rarkins commented Feb 19, 2024

Do these repos all release synchronized versions at the same time?

I'm not sure exactly what you're asking - but i don't think so. As in, if packages in the main repo are updated, this does not automatically mean a release of .DevTools and/or .Typescript, the author seems to keep things seperate in that regard. I can imagine if there are breaking changes all packages of all git repos would be updated.

Would you like me to remove those and then simply refer to the main repo?

If they are from separate repos, and they don't have the same/synchronized versions, then it's not qualified for our "monorepo" grouping. Instead it could be part of group:recommended if you think people usually should update them together at once

@sommmen
Copy link
Contributor Author

sommmen commented Feb 19, 2024

Do these repos all release synchronized versions at the same time?

I'm not sure exactly what you're asking - but i don't think so. As in, if packages in the main repo are updated, this does not automatically mean a release of .DevTools and/or .Typescript, the author seems to keep things seperate in that regard. I can imagine if there are breaking changes all packages of all git repos would be updated.
Would you like me to remove those and then simply refer to the main repo?

If they are from separate repos, and they don't have the same/synchronized versions, then it's not qualified for our "monorepo" grouping. Instead it could be part of group:recommended if you think people usually should update them together at once

I think just having the one monorepo in there is the way to go about things. Updated the PR, hopefully to satisfaction this time. Apologies for the initial wrongful pr.

@rarkins rarkins added this pull request to the merge queue Feb 19, 2024
Merged via the queue into renovatebot:main with commit c90b22b Feb 19, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.200.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants