feat(platform): add support for the SCM-manager #26866
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zT-1337
changed the title
zT-1337
changed the title
- SCM-Manager is a repository management tool like GitHub - It is maintained as an open source project by the company [Cloudogu](https://cloudogu.com/en/) - The SCM-Manager support is not feature complete yet, features like auto merging are still missing - The SCM-Manager also got added to the documentation as another platform author Thomas Zerr <thomas.zerr@cloudogu.com> 1690877165 +0200 committer Eduard Heimbuch <eduard.heimbuch@cloudogu.com> 1706264263 +0100
zT-1337
force-pushed
the
feat/scm-manager-support
branch
from
4a0f4a0
to
e3780f7
Compare
viceice
requested changes
Jan 26, 2024
viceice
reviewed
Jan 30, 2024
HonkingGoose
suggested changes
Jan 31, 2024
zT-1337
changed the title
HonkingGoose
suggested changes
Feb 21, 2024
viceice
reviewed
Feb 22, 2024
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
suggested changes
Aug 3, 2024
Comment on lines
+282
to
+298
| [[], pullRequest.source, pullRequest.title, 'all', null], | ||
| [[pullRequest], 'invalid branchName', pullRequest.title, 'all', null], | ||
| [[pullRequest], pullRequest.source, 'invalid title', 'all', null], | ||
| [[pullRequest], pullRequest.source, null, 'all', renovatePr], | ||
| [[pullRequest], pullRequest.source, undefined, 'all', renovatePr], | ||
| [[pullRequest], pullRequest.source, pullRequest.title, 'all', renovatePr], | ||
| [ | ||
| [pullRequest], | ||
| pullRequest.source, | ||
| pullRequest.title, | ||
| 'open', | ||
| renovatePr, | ||
| ], | ||
| [[pullRequest], pullRequest.source, pullRequest.title, '!open', null], | ||
| [[pullRequest], pullRequest.source, pullRequest.title, 'closed', null], | ||
| ])( | ||
| 'search within %p for %p, %p, %p with result %p', |
There was a problem hiding this comment.
This code looks hard to understand and maintain.
I don't know what 'search within %p for %p, %p, %p with result %p', means here.
Maybe a maintainer can suggest improvements?
There was a problem hiding this comment.
The %p is a string formatter. It injects the test parameters depending on the position of the formatter. So the first test case would be printed as search within [] for feature/test, The PullRequest, all, null. This would help to identify for which parameters the test case failed.
There was a problem hiding this comment.
Any suggestions on how to improve this?
| [[pullRequest], 'invalid branchName', null], | ||
| [[pullRequest], pullRequest.source, renovatePr], | ||
| ])( | ||
| 'search within %p for %p with result %p', |
There was a problem hiding this comment.
Same thing here with three references to %p.
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
viceice
reviewed
Aug 5, 2024
|
|
||
| const result = { | ||
| defaultBranch: config.defaultBranch, | ||
| isFork: false, |
There was a problem hiding this comment.
Suggested change
| isFork: false, |
false is the default value. no fork support on scam manager?
There was a problem hiding this comment.
No, the scm-manager does not provide a support for forking.
Just deleting this line, does not work because TypeScript would complain about the missing property, because it is not defined as an optional.
export interface RepoResult {
defaultBranch: string;
isFork: boolean;
repoFingerprint: string;
}
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: