fix(datasource/npm): respect abortOnError
hostRule for registries
#26196
+116
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adjusts the npm datasource to respect hostRules with
abortOnError
.This is archived through checking if the http request throws an
ExternalHostError
and if yes will throw them up.To keep the existing logic of aborting on
registry.npmjs.com
it checks if a hostRule with an explicitabortOnError
setting exists and only if not we will add a custom hostRule settingabortOnError: true
forregistry.npmjs.com
. This allows as well to explicitly opt-out ofabortOnError
forregistry.npmjs.com
withabortOnError: false
.Context
Fixes #13482
Additionally it allows to set abortOnError for custom registries, which is a use-case I currently have.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
abortOnError: true
=> aborts runabortOnError
=> doesn't abort runregistry.npmjs.org
withoutabortOnError
=> aborts runregistry.npmjs.org
withabortOnError: false
=> doesn't abort run