Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update dependency simple-git to v3 #13705

Merged
merged 5 commits into from
Jan 27, 2022
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 21, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
simple-git 2.48.0 -> 3.0.2 age adoption passing confidence

Release Notes

steveukx/git-js

v3.0.2

Compare Source

v3.0.1

Compare Source


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@viceice
Copy link
Member

viceice commented Jan 21, 2022

Will fix this soon

@viceice viceice self-requested a review January 21, 2022 08:46
@rarkins
Copy link
Collaborator

rarkins commented Jan 21, 2022

Strange that we're missing notes from the changelog: https://github.com/steveukx/git-js/blob/main/CHANGELOG.md

@renovate renovate bot force-pushed the renovate/simple-git-3.x branch from a1337aa to 8194bed Compare January 21, 2022 10:50
@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Jan 21, 2022

Strange that we're missing notes from the changelog: https://github.com/steveukx/git-js/blob/main/CHANGELOG.md

I think they have a "monorepo setup", but their packages/*/package.json files do not mention the location of the files, so Renovate doesn't know where to grab the release notes?

Edit: Monorepo setup confirmed: steveukx/git-js#716
Edit: The git-js/simple-git/package.json does not have the directory property: https://github.com/steveukx/git-js/blob/main/simple-git/package.json

Quote from the npm 8 docs: 1

If the package.json for your package is not in the root directory (for example if it is part of a monorepo), you can specify the directory in which it lives:

{
  "repository": {
    "type": "git",
    "url": "https://github.com/facebook/react.git",
    "directory": "packages/react-dom"
  }
}

Footnotes

  1. https://docs.npmjs.com/cli/v8/configuring-npm/package-json#repository

@rarkins
Copy link
Collaborator

rarkins commented Jan 21, 2022

I thought we still fell back to the root CHANGELOG though

@renovate renovate bot force-pushed the renovate/simple-git-3.x branch 22 times, most recently from 7e71b40 to 594b926 Compare January 23, 2022 21:26
@renovate renovate bot force-pushed the renovate/simple-git-3.x branch 3 times, most recently from 9e0dbbc to fd3fa6d Compare January 25, 2022 13:38
@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Jan 25, 2022

I thought we still fell back to the root CHANGELOG though

@rarkins Would the logs for the Renovate run on this branch show what happens? Maybe you can see why it's not falling back to the root changelog.

We do have release notes now though for some reason...


Edit: And now the release notes are gone again. Check out the edit history for the PR body in the top comment, it's doing some flip-flopping now...

@renovate renovate bot force-pushed the renovate/simple-git-3.x branch 6 times, most recently from 1518698 to 314333b Compare January 26, 2022 10:55
@HonkingGoose
Copy link
Collaborator

This is one weird edit history for this PR...

From oldest edit to most recent one (at time of writing):

  1. simple-git from 2.48.0 -> 3.0.3
  2. simple-git from 2.48.0 -> 3.0.4 <-- new patch release
  3. simple-git from 2.48.0 -> 3.1.0 <-- new minor release
  4. simple-git from 2.48.0 -> 3.0.1 <-- reverting to older version
  5. simple-git from 2.48.0 -> 3.0.2 <-- bumping old version one patch

@viceice
Copy link
Member

viceice commented Jan 26, 2022

It's probably the stability days value

@renovate renovate bot force-pushed the renovate/simple-git-3.x branch 3 times, most recently from f05349f to 593fdec Compare January 26, 2022 17:07
@renovate renovate bot force-pushed the renovate/simple-git-3.x branch from 593fdec to 9f3a2e0 Compare January 27, 2022 01:15
@renovate renovate bot requested a review from JamieMagee as a code owner January 27, 2022 09:46
@viceice viceice requested a review from rarkins January 27, 2022 11:02
@viceice viceice merged commit 859290b into main Jan 27, 2022
@viceice viceice deleted the renovate/simple-git-3.x branch January 27, 2022 11:22
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.58.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants