Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): create versioning as proxy of npm #12132

Merged
merged 6 commits into from
Oct 20, 2021

Conversation

secustor
Copy link
Collaborator

Changes:

Add a helm versioning implementation as proxy to npm as it has a subset of its capabilities.

Context:

This is the result from a discussion in the RenovateBot Slack workspace.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Oct 13, 2021

@secustor were you planning further work after this? I don't see what difference this practically makes until at least one of the functions differs from npm's implementation.

@secustor
Copy link
Collaborator Author

Not at the moment.
They simply differ in the testcases. As helm supports a subset of npm options.

If there are more differences surfacing like npm changing its behavior. We have an API to change without breaking the user configs.
Further I think it is more straight forward to users to use helm versioning for helm than npm

@rarkins rarkins enabled auto-merge (squash) October 20, 2021 11:26
@rarkins rarkins merged commit 27812e9 into renovatebot:main Oct 20, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 28.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2021
@secustor secustor deleted the support_tilde_helm_requirements branch December 4, 2022 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants