-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: move chartmuseum info into private packages page #12095
docs: move chartmuseum info into private packages page #12095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 i think this is better suited at helm datasource or our private modules page.
It should also have a hostType
to not collide with default host rules.
@HonkingGoose this applies to standard helm repositories as well (not hosted via chartmuseum), so I believe the docs should reflect that |
That runs the risk of duplicating the information in multiple places though. I'd prefer to have a single location for this text. I'm okay with adding links to the canonical text in other places. |
🎉 This PR is included in version 28.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
getting-started/private-packages.md
helm-requirements/readme.md
EDIT: Updated the changes section, kept the original context at time of opening the issue.
Context:
@dudicoco said 1 that the chartmuseum information that's placed in the Docker docs should go in the
helm-requirements
manager docs instead.I don't know if I can use a
h2
heading in this file, or if that will mess up the display of the published page. I think no other manager readme file has headings in it? The pattern to check would belib/manager/manager-name/readme.md
.Turns out I'm not allowed to use
h1
orh2
headings. 🙈I'm not sure if this is a better place than in the Docker docs, it depends where people will think to look.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
Footnotes
https://github.com/renovatebot/renovate/issues/12093 ↩