Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add build capture group to regex docs #12065

Merged

Conversation

HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented Oct 7, 2021

Changes:

  • Add build capture group to regex docs
  • Use one sentence per line
  • Fix some grammar problems

Context:

As requested by @viceice 1.
PR #11115 added the build capture group feature.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Footnotes

  1. https://github.com/renovatebot/renovate/discussions/12063#discussioncomment-1443330

@HonkingGoose HonkingGoose requested a review from viceice October 7, 2021 17:45
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@HonkingGoose HonkingGoose requested a review from viceice October 7, 2021 18:32
@viceice viceice requested a review from rarkins October 7, 2021 18:36
@rarkins rarkins enabled auto-merge (squash) October 8, 2021 04:13
@rarkins rarkins merged commit a9c9aa0 into renovatebot:main Oct 8, 2021
@HonkingGoose HonkingGoose deleted the docs/add-build-capture-group-regex branch October 8, 2021 08:09
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants